Tween engine?

  ... the case you feel the need for a new feature or want to submit one.

Re: Tween engine?

Postby gilamran » Sat Jul 24, 2010 12:36 am

ok, I've started working on it.

few things in mind:
1. Your code is great! loved the way you used the interfaces and inheritance! finally I see generice code (But...)
2. I don't really like the BaseDoubleValue, BaseTripleValue classes implementation... they should do composition and not inheritance... (Adding the interpolation classes now proves it was wrong to use inheritance)
3. I'm not soo good in Java, so you'll have to forgive my coding, you'll have to review it to the bone.

comments?

I have something working...
gilamran
 
Posts: 36
Joined: Fri Jul 16, 2010 8:56 pm

Re: Tween engine?

Postby Nicolas Gramlich » Sat Jul 24, 2010 12:42 am

Yeah the BaseSingle/Double/Triple-Value stuff felt always a bit wrong... :lol:
Let me know when you have sth i can take a look at :)

Best Regards,
Nicolas
Nicolas Gramlich
Site Admin
 
Posts: 1734
Joined: Mon Jun 07, 2010 6:20 pm
Location: Schriesheim, Germany

Re: Tween engine?

Postby gilamran » Sun Jul 25, 2010 10:36 am

Attached is a demo of all the easing functions working with the engine.
your comments.

Gil.
Attachments
AndEngineMinimalExmaple.apk
A Demo
(126.76 KiB) Downloaded 221 times
gilamran
 
Posts: 36
Joined: Fri Jul 16, 2010 8:56 pm

Re: Tween engine?

Postby Nicolas Gramlich » Sun Jul 25, 2010 11:05 am

Wow that is really nice :!:
(I think there might be a bug with the "ELASTIC_IN", "ELASTIC_OUT" and "ELASTIC_IN_OUT", as the first one seems to jump from the middle to the end and the second one starts in the middle, the last one also is a little jumpy. But maybe its the desired behavior.

Are you planning to contribute these changes back? You probably have to anyway :P
Did you clone the repository? That would be the easiest to merge the changes back in.

Again great work :)

Best Regards,
Nicolas
Nicolas Gramlich
Site Admin
 
Posts: 1734
Joined: Mon Jun 07, 2010 6:20 pm
Location: Schriesheim, Germany

Re: Tween engine?

Postby Nicolas Gramlich » Sun Jul 25, 2010 11:07 am

Wow that is really nice :!:
(I think there might be a bug with the "ELASTIC_IN", "ELASTIC_OUT" and "ELASTIC_IN_OUT", as the first one seems to jump from the middle to the end and the second one starts in the middle, the last one also is a little jumpy. But maybe its the desired behavior.

Are you planning to contribute these changes back? You probably have to anyway :P
Did you clone the repository? That would be the easiest to merge the changes back in.

(Oh and did you originate this from your own code? Just asking due to possible licensing issues.)

Again great work :)

Best Regards,
Nicolas
Nicolas Gramlich
Site Admin
 
Posts: 1734
Joined: Mon Jun 07, 2010 6:20 pm
Location: Schriesheim, Germany

Re: Tween engine?

Postby gilamran » Sun Jul 25, 2010 11:13 am

hoo, yea I have a bug in the Elastic calculations.
sure, I'd love to contribute it.

few things:
1. I should fix the bug (can be done tonight)
2. I never worked with this kind of source-control... I remember that I did clone the source. we'll have to talk about the merge.
3. The commit will break the old code, there's a new parameter to all the modifiers (EasingFunction), maybe we can have a default LINEAR...

Gil.
gilamran
 
Posts: 36
Joined: Fri Jul 16, 2010 8:56 pm

Re: Tween engine?

Postby Nicolas Gramlich » Sun Jul 25, 2010 1:01 pm

I can merge it in, no problem. Wouldn't be the first time for me :)
And as you said I could look over the code and adapt the coding style so it feels like the rest of AndEngine, when being read.

On this page: http://code.google.com/p/andengine/source/clones you can see a button "Create a Clone" which would have been the easiest, as you could simply have pushed your changes into your clone and I would have pulled and merged them in.

The last option is to send me a mail and I'll merge it in manually. :)

I'm very excited about your stuff :) ( Oh and btw I also liked how you implemented your example :) )

Best Regards,
Nicolas
Nicolas Gramlich
Site Admin
 
Posts: 1734
Joined: Mon Jun 07, 2010 6:20 pm
Location: Schriesheim, Germany

Re: Tween engine?

Postby gilamran » Sun Jul 25, 2010 3:00 pm

OK, I'm trying to do the clone thing (First time)
1. I did the clone (gilamran-ease)
2. I'll check it out tonight.
3. port my changes into this clone.

Now how do I push it back for review?

btw: Thanks! love to help open-source!
Gil
gilamran
 
Posts: 36
Joined: Fri Jul 16, 2010 8:56 pm

Re: Tween engine?

Postby Nicolas Gramlich » Sun Jul 25, 2010 3:30 pm

Okay fine, which one is it: http://code.google.com/p/andengine/source/clones ^^

How familiar are you with Mercurial?

Best Regards,
Nicolas
Nicolas Gramlich
Site Admin
 
Posts: 1734
Joined: Mon Jun 07, 2010 6:20 pm
Location: Schriesheim, Germany

Re: Tween engine?

Postby gilamran » Sun Jul 25, 2010 3:32 pm

This is my clone: http://code.google.com/r/gilamran-ease/source/checkout
I know nothing about Mercurial... (Sorry)
gilamran
 
Posts: 36
Joined: Fri Jul 16, 2010 8:56 pm

PreviousNext

Return to Features

Who is online

Users browsing this forum: No registered users and 7 guests